linux-kernel - Re: [PATCH v3 5/5] firmware: add an extensible system data helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Dec 2015 06:26:39 +0800
From:	kbuild test robot <lkp@...el.com>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	kbuild-all@...org, gregkh@...uxfoundation.org,
	ming.lei@...onical.com, jwboyer@...oraproject.org,
	johannes@...solutions.net, luto@...capital.net, corbet@....net,
	dwmw2@...radead.org, dhowells@...hat.com,
	seth.forshee@...onical.com, rusty@...tcorp.com.au, mmarek@...e.cz,
	mjg59@...f.ucam.org, kyle@...nel.org, zohar@...ux.vnet.ibm.com,
	dmitry.kasatkin@...il.com, vgoyal@...hat.com,
	computersforpeace@...il.com, keescook@...omium.org,
	shuahkh@....samsung.com, torvalds@...ux-foundation.org,
	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	linux-kernel@...r.kernel.org, "Luis R. Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH v3 5/5] firmware: add an extensible system data helpers

Hi Luis,

[auto build test WARNING on v4.4-rc6]
[also build test WARNING on next-20151223]

url:    https://github.com/0day-ci/linux/commits/Luis-R-Rodriguez/firmware_class-extensible-firmware-API/20151224-053852
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   include/linux/init.h:1: warning: no structured comments found
   kernel/sys.c:1: warning: no structured comments found
>> drivers/base/firmware_class.c:1336: warning: No description found for parameter 'sysdata'
>> drivers/base/firmware_class.c:1336: warning: Excess function parameter 'sysdata_file' description in 'release_sysdata_file'
   drivers/dma-buf/seqno-fence.c:1: warning: no structured comments found
   drivers/dma-buf/reservation.c:1: warning: no structured comments found
   include/linux/reservation.h:1: warning: no structured comments found
   include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'e_handler' description in 'hsi_client'
   include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'pclaimed' description in 'hsi_client'
   include/linux/hsi/hsi.h:150: warning: Excess struct/union/enum/typedef member 'nb' description in 'hsi_client'

vim +/sysdata +1336 drivers/base/firmware_class.c

  1320				__func__);
  1321			return -ENOMEM;
  1322		}
  1323	
  1324		ret = _request_firmware_prepare(&fw, name, device);
  1325		if (ret >= 0)
  1326			sysdata->priv = fw;
  1327	
  1328		return ret;
  1329	}
  1330	
  1331	/**
  1332	 * release_sysdata_file: - release the resource associated with the sysdata file
  1333	 * @sysdata_file: sysdata resource to release
  1334	 **/
  1335	void release_sysdata_file(const struct sysdata_file *sysdata)
> 1336	{
  1337		struct firmware *fw;
  1338	
  1339		if (sysdata) {
  1340			if (sysdata->priv) {
  1341				fw = sysdata->priv;
  1342				release_firmware(fw);
  1343			}
  1344		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6124 bytes)