linux-kernel - Re: [PATCH] staging: lustre: fix lock imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201512271304.WTOn4QvD%fengguang.wu@intel.com>
Date:	Sun, 27 Dec 2015 13:32:46 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Joshua Clayton <stillcompiling@...il.com>
Cc:	kbuild-all@...org, Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	lustre-devel@...ts.lustre.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Joshua Clayton <stillcompiling@...il.com>
Subject: Re: [PATCH] staging: lustre: fix lock imbalance

[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
Hi Joshua,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.4-rc6 next-20151223]

url:    https://github.com/0day-ci/linux/commits/Joshua-Clayton/staging-lustre-fix-lock-imbalance/20151227-131137
config: x86_64-allyesconfig (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/staging/lustre/lustre/ptlrpc/nrs.c: In function 'nrs_resource_put_safe':
>> drivers/staging/lustre/lustre/ptlrpc/nrs.c:485:21: warning: unused variable 'nrs' [-Wunused-variable]
     struct ptlrpc_nrs *nrs = NULL;
                        ^

vim +/nrs +485 drivers/staging/lustre/lustre/ptlrpc/nrs.c

d7e09d039 Peng Tao 2013-05-02  469  			nrs_policy_put(primary);
d7e09d039 Peng Tao 2013-05-02  470  	}
d7e09d039 Peng Tao 2013-05-02  471  }
d7e09d039 Peng Tao 2013-05-02  472  
d7e09d039 Peng Tao 2013-05-02  473  /**
d7e09d039 Peng Tao 2013-05-02  474   * Releases references to resource hierarchies and policies, because they are no
d7e09d039 Peng Tao 2013-05-02  475   * longer required; used when request handling has been completed, or the
d7e09d039 Peng Tao 2013-05-02  476   * request is moving to the high priority NRS head.
d7e09d039 Peng Tao 2013-05-02  477   *
d7e09d039 Peng Tao 2013-05-02  478   * \param resp	the resource hierarchy that is being released
d7e09d039 Peng Tao 2013-05-02  479   *
d7e09d039 Peng Tao 2013-05-02  480   * \see ptlrpc_nrs_req_finalize()
d7e09d039 Peng Tao 2013-05-02  481   */
d7e09d039 Peng Tao 2013-05-02  482  static void nrs_resource_put_safe(struct ptlrpc_nrs_resource **resp)
d7e09d039 Peng Tao 2013-05-02  483  {
d7e09d039 Peng Tao 2013-05-02  484  	struct ptlrpc_nrs_policy *pols[NRS_RES_MAX];
d7e09d039 Peng Tao 2013-05-02 @485  	struct ptlrpc_nrs *nrs = NULL;
d7e09d039 Peng Tao 2013-05-02  486  	int i;
d7e09d039 Peng Tao 2013-05-02  487  
d7e09d039 Peng Tao 2013-05-02  488  	for (i = 0; i < NRS_RES_MAX; i++) {
d7e09d039 Peng Tao 2013-05-02  489  		if (resp[i] != NULL) {
d7e09d039 Peng Tao 2013-05-02  490  			pols[i] = resp[i]->res_policy;
d7e09d039 Peng Tao 2013-05-02  491  			nrs_resource_put(resp[i]);
d7e09d039 Peng Tao 2013-05-02  492  			resp[i] = NULL;
d7e09d039 Peng Tao 2013-05-02  493  		} else {

:::::: The code at line 485 was first introduced by commit
:::::: d7e09d0397e84eefbabfd9cb353221f3c6448d83 staging: add Lustre file system client support

:::::: TO: Peng Tao <bergwolf@...il.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (51410 bytes)