linux-kernel - Re: [PATCH v2 00/12] mtd: nand_bbt: introduce independent nand BBT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Dec 2015 17:42:50 -0300
From:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
To:	Peter Pan <peterpansjtu@...il.com>
Cc:	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	fransklaver@...il.com, Peter Pan <peterpandong@...ron.com>,
	beanhuo@...ron.com,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	karlzhang@...ron.com
Subject: Re: [PATCH v2 00/12] mtd: nand_bbt: introduce independent nand BBT

This is looking a lot better, thanks for the good work!

On 15 December 2015 at 02:59, Peter Pan <peterpansjtu@...il.com> wrote:
> Currently nand_bbt.c is tied with struct nand_chip, and it makes other
> NAND family chips hard to use nand_bbt.c. Maybe it's the reason why
> onenand has own bbt(onenand_bbt.c).
>
> Separate struct nand_chip from BBT code can make current BBT shareable.
> We create struct nand_bbt to take place of nand_chip in nand_bbt.c.
> Struct nand_bbt contains all the information BBT needed from outside and
> it should be embedded into NAND family chip struct (such as struct nand_chip).
> NAND family driver should allocate, initialize and free struct nand_bbt.
>
> Below is mtd folder structure we want:
>         mtd
>         ├── Kconfig
>         ├── Makefile
>         ├── ...
>         ├── nand_bbt.c

Hm.. I'm not sure about having nand_bbt.c in drivers/mtd.
What's wrong with drivers/mtd/nand ?

In fact, I  was thinking we could go further and clean up the directories a bit
by separating core code, from controllers code, from SPI NAND code:

drivers/mtd/nand/
drivers/mtd/nand/controllers
drivers/mtd/nand/spi

Makes any sense?
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/