linux-kernel - Re: [PATCH] ALSA: cs5535audio: constify cs5535audio_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8u4btxkp.wl-tiwai@suse.de>
Date:	Wed, 30 Dec 2015 22:51:02 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Julia Lawall" <Julia.Lawall@...6.fr>
Cc:	"Jaya Kumar" <jayakumar.alsa@...il.com>,
	<alsa-devel@...a-project.org>, "Jaroslav Kysela" <perex@...ex.cz>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: cs5535audio: constify cs5535audio_dma_ops structures

On Wed, 30 Dec 2015 11:44:53 +0100,
Julia Lawall wrote:
> 
> The cs5535audio_dma_ops structures are never modified, so declare them as
> const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied, thanks.


Takashi

> 
> ---
>  sound/pci/cs5535audio/cs5535audio_pcm.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/cs5535audio/cs5535audio_pcm.c b/sound/pci/cs5535audio/cs5535audio_pcm.c
> index 9c2dc91..27fa57d 100644
> --- a/sound/pci/cs5535audio/cs5535audio_pcm.c
> +++ b/sound/pci/cs5535audio/cs5535audio_pcm.c
> @@ -402,7 +402,7 @@ static struct snd_pcm_ops snd_cs5535audio_capture_ops = {
>  	.pointer =	snd_cs5535audio_pcm_pointer,
>  };
>  
> -static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
>          .type = CS5535AUDIO_DMA_PLAYBACK,
>          .enable_dma = cs5535audio_playback_enable_dma,
>          .disable_dma = cs5535audio_playback_disable_dma,
> @@ -412,7 +412,7 @@ static struct cs5535audio_dma_ops snd_cs5535audio_playback_dma_ops = {
>          .read_dma_pntr = cs5535audio_playback_read_dma_pntr,
>  };
>  
> -static struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
> +static const struct cs5535audio_dma_ops snd_cs5535audio_capture_dma_ops = {
>          .type = CS5535AUDIO_DMA_CAPTURE,
>          .enable_dma = cs5535audio_capture_enable_dma,
>          .disable_dma = cs5535audio_capture_disable_dma,
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/