linux-kernel - Re: [PATCH] ALSA: dummy: constify dummy_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h7fjvtxkf.wl-tiwai@suse.de>
Date:	Wed, 30 Dec 2015 22:51:12 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Julia Lawall" <Julia.Lawall@...6.fr>
Cc:	"Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
	<kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: dummy: constify dummy_timer_ops structures

On Wed, 30 Dec 2015 12:28:49 +0100,
Julia Lawall wrote:
> 
> The dummy_timer_ops structures are never modified, so declare them as
> const.
> 
> Done with the help of Coccinelle.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Applied, thanks.


Takashi

> 
> ---
>  sound/drivers/dummy.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/drivers/dummy.c b/sound/drivers/dummy.c
> index 016e451..75b7485 100644
> --- a/sound/drivers/dummy.c
> +++ b/sound/drivers/dummy.c
> @@ -351,7 +351,7 @@ static void dummy_systimer_free(struct snd_pcm_substream *substream)
>  	kfree(substream->runtime->private_data);
>  }
>  
> -static struct dummy_timer_ops dummy_systimer_ops = {
> +static const struct dummy_timer_ops dummy_systimer_ops = {
>  	.create =	dummy_systimer_create,
>  	.free =		dummy_systimer_free,
>  	.prepare =	dummy_systimer_prepare,
> @@ -475,7 +475,7 @@ static void dummy_hrtimer_free(struct snd_pcm_substream *substream)
>  	kfree(dpcm);
>  }
>  
> -static struct dummy_timer_ops dummy_hrtimer_ops = {
> +static const struct dummy_timer_ops dummy_hrtimer_ops = {
>  	.create =	dummy_hrtimer_create,
>  	.free =		dummy_hrtimer_free,
>  	.prepare =	dummy_hrtimer_prepare,
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/