linux-kernel - Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6416183.AAnzQivnkS@wuerfel>
Date:	Thu, 31 Dec 2015 15:12:11 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>,
	y2038@...ts.linaro.org, gregkh@...uxfoundation.org,
	broonie@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [Y2038] [PATCH v2 2/2] ppdev: add support for compat ioctl

On Thursday 31 December 2015 15:13:08 Sudip Mukherjee wrote:
> On Wed, Dec 30, 2015 at 10:20:58PM +0800, Bamvor Jian Zhang wrote:
> > On 12/30/2015 09:51 PM, Arnd Bergmann wrote:
> > > On Wednesday 30 December 2015 21:24:21 Bamvor Jian Zhang wrote:
> > >> diff --git a/drivers/char/ppdev.c b/drivers/char/ppdev.c
> > > This is something that would be caught by running 'make C=1' with 'sparse'
> > > on your patch. Can you try that to see if you introduce any other warnings?
> > OK. I do not do it before, there is no extra warning after apply the above
> > patch.
> > > I'm guessing it's fine, but it would be nice to confirm. I also send a lot
> > > of patches without running sparse and checkpatch first, but it's generally
> > > a good idea.
> > Got you. I only do the checkpatch in past. I will do sparse and checkpatch
> > in future.
> 
> Usually sparse will be part of the tests that are done by 0day.
> Anyway, it worked perfectly in 64bit systems also. Can you please send
> your patch v3  with this change..
> 

Ah, cool, thanks so much for testing.

Did you happen to check with both 32-bit and 64-bit user space on a
64-bit kernel? This is one of the things that was not working originally
but should work now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/