linux-kernel - Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151231210638.GA11763@earth>
Date:	Thu, 31 Dec 2015 22:06:38 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	"Andrew F. Davis" <afd@...com>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx
 driver.

Hi,

On Thu, Dec 31, 2015 at 07:40:04PM +0100, Pali Rohár wrote:
> On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> > Signed-off-by: Andrew F. Davis <afd@...com>
> > ---
> >  MAINTAINERS | 10 ++++++++--
> >  1 file changed, 8 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 44666b1..046d001 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> >  M:	Pali Rohár <pali.rohar@...il.com>
> >  S:	Maintained
> >  F:	include/linux/power/bq2415x_charger.h
> > -F:	include/linux/power/bq27xxx_battery.h
> >  F:	include/linux/power/isp1704_charger.h
> >  F:	drivers/power/bq2415x_charger.c
> > -F:	drivers/power/bq27xxx_battery.c
> >  F:	drivers/power/isp1704_charger.c
> >  F:	drivers/power/rx51_battery.c
> 
> I think it is not needed to remove files from this section as here are 
> all power supply files for Nokia N900.
>
> > @@ -10710,6 +10708,14 @@ L:	linux-omap@...r.kernel.org
> >  S:	Maintained
> >  F:	drivers/thermal/ti-soc-thermal/
> > 
> > +TI BQ27XXX POWER SUPPLY DRIVER
> > +M:	Pali Rohár <pali.rohar@...il.com>
> > +R:	Andrew F. Davis <afd@...com>
> > +S:	Maintained
> > +F:	include/linux/power/bq27xxx_battery.h
> > +F:	drivers/power/bq27xxx_battery.c
> > +F:	drivers/power/bq27xxx_battery_i2c.c

I think it would make sense to have it like this:

NOKIA N900 POWER SUPPLY DRIVERS
+R:	Pali Rohár <pali.rohar@...il.com>
-M:	Pali Rohár <pali.rohar@...il.com>
-S:	Maintained
F:	include/linux/power/bq2415x_charger.h
F:	include/linux/power/bq27xxx_battery.h
F:	include/linux/power/isp1704_charger.h
F:	drivers/power/bq2415x_charger.c
F:	drivers/power/bq27xxx_battery.c
F:	drivers/power/isp1704_charger.c
F:	drivers/power/rx51_battery.c

+TI BQ27XXX POWER SUPPLY DRIVER
+R:	Andrew F. Davis <afd@...com>
+F:	include/linux/power/bq27xxx_battery.h
+F:	drivers/power/bq27xxx_battery.c
+F:	drivers/power/bq27xxx_battery_i2c.c
+
POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
M:	Sebastian Reichel <sre@...nel.org>
M:	Dmitry Eremin-Solenikov <dbaryshkov@...il.com>
M:	David Woodhouse <dwmw2@...radead.org>
L:	linux-pm@...r.kernel.org
T:	git git://git.infradead.org/battery-2.6.git
S:	Maintained
F:	include/linux/power_supply.h
F:	drivers/power/
X:	drivers/power/avs/

This would result in the following get_maintainer.pl output
for the bq27xxx driver.

sre@...th ~/src/linux [n950] % ./scripts/get_maintainer.pl -f drivers/power/bq27xxx_battery.c 
"Andrew F. Davis" <afd@...com> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER)
"Pali Rohár" <pali.rohar@...il.com> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
Sebastian Reichel <sre@...nel.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
Dmitry Eremin-Solenikov <dbaryshkov@...il.com> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
David Woodhouse <dwmw2@...radead.org> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-pm@...r.kernel.org (open list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
linux-kernel@...r.kernel.org (open list)

Pali, what do you think about the reviewer/maintainer change?
I think it makes it more clear, that the patches are queued in
the battery tree. If you think its a downgrade I don't mind not
changing it, though.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)