linux-kernel - Re: [PATCH v1 1/3] i2c: rk3x: add calc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160104194042.GD1522@katana>
Date:	Mon, 4 Jan 2016 20:40:42 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Jianqun Xu <jay.xu@...k-chips.com>, David Wu <wdc@...k-chips.com>,
	Heiko Stübner <heiko@...ech.de>,
	dianders@...omium.org, huangtao@...k-chips.com, zyw@...k-chips.com,
	hl@...k-chips.com, xjq@...k-chips.com,
	linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
	linux-rockchip@...ts.infradead.org, linux-i2c@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Wu <david.wu@...k-chips.com>
Subject: Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version

> >> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
> >> scl_rate,
> >> +                                unsigned long scl_rise_ns,
> >> +                                unsigned long scl_fall_ns,
> >> +                                unsigned long sda_fall_ns,
> 
> Wolfram did some sturct to assign the parameters from device properties.
> It might be re-used here.

Yes, I think it makes sense to convert the driver first to use
the new i2c_parse_fw_timings() function and see if it fits (or if we need
to extend it perhaps).

David, does this make sense to you?


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)