[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <568FB5BD.9050809@rock-chips.com>
Date: Fri, 8 Jan 2016 21:12:29 +0800
From: "David.Wu" <wdc@...k-chips.com>
To: Wolfram Sang <wsa@...-dreams.de>,
Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jianqun Xu <jay.xu@...k-chips.com>,
Heiko Stübner <heiko@...ech.de>,
dianders@...omium.org, huangtao@...k-chips.com, zyw@...k-chips.com,
hl@...k-chips.com, xjq@...k-chips.com,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
linux-rockchip@...ts.infradead.org, linux-i2c@...r.kernel.org,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
David Wu <david.wu@...k-chips.com>
Subject: Re: [PATCH v1 1/3] i2c: rk3x: add calc_divs ops for new version
Hi Wolfram, Andy
Thanks for your suggestion.
I will use i2c_parse_fw_timings() function to replace it.
在 2016/1/5 3:40, Wolfram Sang 写道:
>>>> +static int rk3x_i2c_v0_calc_divs(unsigned long clk_rate, unsigned long
>>>> scl_rate,
>>>> + unsigned long scl_rise_ns,
>>>> + unsigned long scl_fall_ns,
>>>> + unsigned long sda_fall_ns,
>> Wolfram did some sturct to assign the parameters from device properties.
>> It might be re-used here.
> Yes, I think it makes sense to convert the driver first to use
> the new i2c_parse_fw_timings() function and see if it fits (or if we need
> to extend it perhaps).
>
> David, does this make sense to you?
>
Powered by blists - more mailing lists