lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Jan 2016 11:06:26 -0500 (EST) From: Alan Stern <stern@...land.harvard.edu> To: Joe Perches <joe@...ches.com> cc: "Geyslan G. Bem" <geyslan@...il.com>, LKML <linux-kernel@...r.kernel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org> Subject: Re: [PATCH 09/17] usb: host: ehci-dbg: fix up function definitions On Tue, 5 Jan 2016, Joe Perches wrote: > On Tue, 2016-01-05 at 10:12 -0500, Alan Stern wrote: > > On Mon, 4 Jan 2016, Geyslan G. Bem wrote: > > > > > >> @@ -404,12 +422,8 @@ static inline char token_mark(struct ehci_hcd *ehci, __hc32 token) > > > >> return '/'; > > > >> } > > > >> > > > >> -static void qh_lines( > > > >> - struct ehci_hcd *ehci, > > > >> - struct ehci_qh *qh, > > > >> - char **nextp, > > > >> - unsigned *sizep > > > >> -) > > > >> +static void qh_lines(struct ehci_hcd *ehci, struct ehci_qh *qh, > > > >> + char **nextp, unsigned *sizep) > > > >> { > > > >> u32 scratch; > > > >> u32 hw_curr; > > > >> > > > > > > > And about that style? Should be done? > > > > You mean squeezing the function parameters into two lines? That's > > okay. > > > > However, the style in this file is to indent continuation lines by two > > extra tab stops, not to line things up with an open paren on the first > > line. > > It's not consistent. > It's a bit of a mix of 1 and 2 tabs, and some others. I know. That's because the files were written by various people at various times and nobody tried to enforce a rigid consistent style. I'm not even consistent all the time in the things that I write. There are places (see drivers/usb/core/config.c) where I indented continuation lines by 4 spaces instead of 2 tab stops. And there are places where a continuation of a continuation gets indented even farther. Trying to come up with hard-and-fast rules for this sort of thing is pretty hopeless. Even "Maximize readability" doesn't work too well, because different people find different things most readable. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists