linux-kernel - Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568CAA97.3080908@nvidia.com>
Date:	Wed, 6 Jan 2016 11:18:07 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<swarren@...dotorg.org>
Subject: Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger
 type


On Tuesday 05 January 2016 11:11 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote:
>
>> +	d->type_reg_stride = chip->type_reg_stride ? : 1;
>> +
> Please don't abuse the ternery operator, especially not the GCC
> extension - that's much less clear than just writing the if statement.
>

Sure, I will not use this in my future coding.
Thanks for correcting this before applying.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/