linux-kernel - Re: [PATCH 2/2] regmap: irq: add support to have callback pre/post irq handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <568CAE65.9030001@nvidia.com>
Date:	Wed, 6 Jan 2016 11:34:21 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<gregkh@...uxfoundation.org>, <linux-kernel@...r.kernel.org>,
	<swarren@...dotorg.org>
Subject: Re: [PATCH 2/2] regmap: irq: add support to have callback pre/post
 irq handling

Resending as previous response was denied by linux-kernel due to html 
format.

On Tuesday 05 January 2016 11:13 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Dec 22, 2015 at 06:25:27PM +0530, Laxman Dewangan wrote:
>> Some of devices like MAXIM MAX77620 required to have the chip
>> specific configuration before processing interrupt and after
>> interrupt handling is done.
> I'd like to see the user for this...
>

This will be there in my next coming patches for PMIC driver from Maxim 
Semiconductor MAX77620/MAX20024.

Per datasheet:

Upon the interrupt hardware line going low (nIRQ=0), the software is 
switched to the priority decoder which decides in what order all 
interrupts to the processor are serviced and therefore, will transfer 
control to the PMIC interrupt service routine appropriately.

* The first task for the processor is to mask the PMIC interrupt by 
setting GLBLM.
     o This forces nIRQ to go high-impedance in which case it will be 
pulled high by the external pull-up resistor.
     o Forcing nRIQ to go high-impedance ensures that any interrupts 
that occur within the PMIC while the PMIC interrupt service routine is 
being executed will cause a subsequent falling edge on the processor 
interrupt line.

* The next task is to read the IRQTOP register and maintain a local 
copy. Note that IRQTOP is cleared when read.
    // Handle all interrupts which occurred from PMIC.

* Once all interrupts have been checked and serviced, the interrupt 
service routine un-masks the hardware interrupt line by clearing (GLBLM).


And typical code will be:

int max77620_top_irq_chip_pre_irq(void *data)
{
         struct max77620_chip *chip = data;

         ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE,
                 MAX77620_REG_INTENLBT, MAX77620_GLBLM_MASK,
                 MAX77620_GLBLM_MASK);
         ::::
}

int max77620_top_irq_chip_post_irq(void *data)
{
         struct max77620_chip *chip = data;

         ret = max77620_reg_update(chip->dev, MAX77620_PWR_SLAVE,
                 MAX77620_REG_INTENLBT, MAX77620_GLBLM_MASK, 0);
         ::::
}

static struct regmap_irq_chip max77620_top_irq_chip = {
         .pre_irq = max77620_top_irq_chip_pre_irq,
         .post_irq = max77620_top_irq_chip_post_irq,
};
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/