linux-kernel - Re: [PATCH v5 9/9] Enable LIVEPATCH to be configured on ppc64le and add livepatch.o if it is selected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160106142315.GM3178@pathway.suse.cz>
Date:	Wed, 6 Jan 2016 15:23:15 +0100
From:	Petr Mladek <pmladek@...e.com>
To:	Torsten Duwe <duwe@....de>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Michael Ellerman <mpe@...erman.id.au>,
	Jiri Kosina <jkosina@...e.cz>,
	Denis Kirjanov <kda@...ux-powerpc.org>,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	live-patching@...r.kernel.org
Subject: Re: [PATCH v5 9/9] Enable LIVEPATCH to be configured on ppc64le and
 add livepatch.o if it is selected.

On Fri 2015-12-04 15:13:44, Torsten Duwe wrote:
> Signed-off-by: Torsten Duwe <duwe@...e.de>
> ---
>  arch/powerpc/Kconfig         | 5 +++++
>  arch/powerpc/kernel/Makefile | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index 89b1a2a..62a3f54 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -163,6 +163,9 @@ config PPC
>  	select ARCH_HAS_DMA_SET_COHERENT_MASK
>  	select HAVE_ARCH_SECCOMP_FILTER
>  
> +config HAVE_LIVEPATCH
> +       def_bool PPC64 && CPU_LITTLE_ENDIAN
> +

Just a small nitpicking. HAVE_LIVEPATCH is defined in
kernel/livepatch/Kconfig. I would move this to the
config PPC section and use:

	select HAVE_LIVEPATCH if PPC64 && CPU_LITTLE_ENDIAN


Or did I miss something, please?

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/