linux-kernel - Re: [PATCH 01/32] mm, gup: introduce concept of "foreign" get_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568D5245.4070409@sr71.net>
Date:	Wed, 6 Jan 2016 09:43:33 -0800
From:	Dave Hansen <dave@...1.net>
To:	Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, x86@...nel.org, dave.hansen@...ux.intel.com,
	akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com,
	aarcange@...hat.com, n-horiguchi@...jp.nec.com
Subject: Re: [PATCH 01/32] mm, gup: introduce concept of "foreign"
 get_user_pages()

On 01/05/2016 02:51 AM, Vlastimil Babka wrote:
> 
> Changelog doesn't mention that get_user_pages_unlocked() is also changed
> to be effectively get_current_user_pages_unlocked(). It's a bit
> non-obvious and the inconsistent naming is unfortunate, but I can see
> how get_current_user_pages_unlocked() would be too long, and just
> deleting the parameters from get_user_pages() would be too large and
> intrusive. But please mention this in changelog?

Thanks for the review!  Good point about the churn there.  I'll add some
changelog comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/