linux-kernel - Re: [PATCH 22/32] x86, pkeys: dump PTE pkey in /proc/pid/smaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <568D52E7.1060602@sr71.net>
Date:	Wed, 6 Jan 2016 09:46:15 -0800
From:	Dave Hansen <dave@...1.net>
To:	Vlastimil Babka <vbabka@...e.cz>, linux-kernel@...r.kernel.org
Cc:	linux-mm@...ck.org, x86@...nel.org, dave.hansen@...ux.intel.com
Subject: Re: [PATCH 22/32] x86, pkeys: dump PTE pkey in /proc/pid/smaps

On 01/05/2016 05:32 AM, Vlastimil Babka wrote:
> On 12/14/2015 08:06 PM, Dave Hansen wrote:
>> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> $SUBJ is a bit confusing in that it's dumping stuff from VMA, not PTE's?

Yeah, absolutely.  That's a relic from when I thought I'd need to be
walking the page tables to figure this out.  I'll update it.

> It could be also useful to extend dump_vma() appropriately. Currently
> there are no string translations for the new "flags" (but one can figure
> it out from the raw value). But maybe we should print pkey separately in
> dump_vma() as you do here. I have a series in flight [1] that touches
> dump_vma() and the flags printing in general, so to avoid conflicts,
> handling pkeys there could wait. But mentioning it now for less chance
> of being forgotten...
> 
> [1] https://lkml.org/lkml/2015/12/18/178 - a previous version is in
> mmotm and this should replace it after 4.5-rc1

Ahhh, very nice.  I'll go back and add support for it once your patch lands.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/