linux-kernel - Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xr3htz1dv.fsf@unicorn.mansr.com>
Date:	Thu, 07 Jan 2016 18:32:28 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Julian Margetson <runaway@...dw.ms>, Tejun Heo <tj@...nel.org>,
	linux-ide@...r.kernel.org,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:

> On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
>> On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård <mans@...sr.com> wrote:
>> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>> > 
>> > > On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
>> > > > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>> > > > 
>> > > > > Here's what I have: https://bitbucket.org/mansr/linux-dwc
>> > > > Bitbucket because Github won't let me have more than one Linux
>> > > > repo.
>> > > 
>> > > Thanks, got it.
>> > > 
>> > > Will base my stuff on what you had done already.
>> > 
>> > I've revived my AVR32 board, and after patching up some unrelated
>> > regressions, the MMC controller is working with the DMA driver as
>> > of 4.4-rc8 as well as with my patches applied.
>> 
>> I'm going to publish my branch tomorrow. It has been tested a bit on
>> Intel hw, and works fine (yours patches are included with some slight
>> changes)
>
> So, Måns, Julian, I just have published my repository containing Måns'
> and my patches regarding dw_dmac and sata_dwc_460ex drivers here
>
> https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext

I've picked out the relevant changes from your branch and made some
additional improvements.  A few notes:

- The __be32/__le32 typedefs for the DMA descriptor fields are necessary
  to avoid a million sparse warnings (and sparse is correct to warn).
- Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver may
  well be used on another big endian system some day.  The Kconfig logic
  for selecting this option could perhaps be improved though.

Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver).

Code here:
https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata

-- 
Måns Rullgård