linux-kernel - Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jan 2016 10:59:20 +0000
From:	Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:	"ynezz@...e.cz" <ynezz@...e.cz>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"stefan@...er.ch" <stefan@...er.ch>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"festevam@...il.com" <festevam@...il.com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"stillcompiling@...il.com" <stillcompiling@...il.com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis
 iMX6Q/D SoM

On Fri, 2016-01-08 at 09:42 +0100, Petr Štetiar wrote:
> Marcel Ziswiler <marcel.ziswiler@...adex.com> [2016-01-06 09:15:18]:
> 
> > > > <&pinctrl_regulator_usbotg_pwr>;
> > > > +			regulator-name = "usb_otg_vbus";
> > > > +			regulator-min-microvolt = <5000000>;
> > > > +			regulator-max-microvolt = <5000000>;
> > > > +			gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> > > > +			enable-active-high;
> > > > +			status = "disabled";
> > > > +		};
> > > 
> > > I'm not sure, but it seems to me, that we should move this
> > > regulator into
> > > the carrier board DTS. On our custom carrier board we've this
> > > regulator
> > > always on and we use this GPIO for heartbeat LED, so I've this in
> > > our
> > > carrier board DTS[2]:
> > 
> > Yes, you are absolutely right and e.g. on Apalis T30 [1] that is
> > exactly how
> > we did it.
> 
> And what about usdhc? It leads to the same overrides in the carrier
> board
> file:
> 
> &iomuxc {
> 	usdhc {
> 		/* GPIO4_IO20 is LVDS */
> 		pinctrl_mmc_cd: gpio_mmc_cd {
> 		};
> 
> 		/* Used as misc GPIOs */
> 		pinctrl_usdhc1: usdhc1grp {
> 		};
> 	};
> };

Yes, the same applies here.

> > > > +/* PAD Ctrl values for common settings */
> > > > +/*
> > > > + * (PAD_CTL_HYS | PAD_CTL_PUS_100K_UP | PAD_CTL_PUE |
> > > > PAD_CTL_PKE
> > > > > 
> > > > + *  PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm)
> > > > + */
> > > > +#define PAD_CTRL_HYS_PU 0x1b0b0
> > > 
> > > This was requested to be reworked. I've simply replaced all the
> > > macros with
> > > hex values.
> > 
> > I don't think the reviewers really concluded on the action to be
> > taken
> > on here and just using hex values is probably the most stupid
> > solution.
> 
> It's simple, if you just leave it as it is, then it will never get
> merged.
> That's how kernel development works :)

Thanks but I don't think you need to explain us how any of this works
(;-p).

>  We've at least two options here:
> 
> 1. Follow the old path and just convert those macros to hex values

Yes, stupid.

> 2. Rework it - move those macros to some header file etc.

As mentioned before I don't think any agreement has been reached.

> -- ynezz


Cheers

Marcel