linux-kernel - Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1452250771.3357.26.camel@toradex.com>
Date:	Fri, 8 Jan 2016 10:59:32 +0000
From:	Marcel Ziswiler <marcel.ziswiler@...adex.com>
To:	"ynezz@...e.cz" <ynezz@...e.cz>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"stefan@...er.ch" <stefan@...er.ch>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"festevam@...il.com" <festevam@...il.com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"stillcompiling@...il.com" <stillcompiling@...il.com>,
	"shawnguo@...nel.org" <shawnguo@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis
 iMX6Q/D SoM

On Fri, 2016-01-08 at 09:57 +0100, Petr Štetiar wrote:
> > +	i2cddc: i2c@0 {
> > +		gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> > +			 &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> > +			>;
> 
> According to one of the comments, it should be changed to the
> following:
> 
> 		sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> 		scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;

No, I believe you mixed the i2c-imx binding with the i2c-gpio one [2].

> -- ynezz


[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-imx.txt
[2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-gpio.txt

Cheers

Marcel