[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJKOXPfOKoV2A1NMyyL5kc=3v6eyTS2T4tRmqM_0=3jBoAZiNg@mail.gmail.com>
Date: Fri, 8 Jan 2016 22:32:37 +0900
From: Krzysztof Kozlowski <k.kozlowski@...sung.com>
To: Laxman Dewangan <ldewangan@...dia.com>
Cc: rtc-linux@...glegroups.com, robh+dt@...nel.org, pawel.moll@....com,
mark.rutland@....com, ijc+devicetree@...lion.org.uk,
galak@...eaurora.org, linus.walleij@...aro.org, gnurou@...il.com,
lee.jones@...aro.org, broonie@...nel.org, a.zummo@...ertech.it,
alexandre.belloni@...e-electrons.com, lgirdwood@...il.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, swarren@...dia.com, treding@...dia.com,
Chaitanya Bandi <bandik@...dia.com>,
Mallikarjun Kasoju <mkasoju@...dia.com>
Subject: Re: [rtc-linux] [PATCH 2/6] mfd: max77620: add core driver for MAX77620/MAX20024
2016-01-08 22:19 GMT+09:00 Laxman Dewangan <ldewangan@...dia.com>:
>
> On Friday 08 January 2016 06:44 PM, Krzysztof Kozlowski wrote:
>>
>>
>> To avoid compilation warning, I need to use inline here.
>> Because this shouldn't be defined in header at the first place. Instead
>> define it in main MFD driver with EXPORT_SYMBOL() and put in headers
>> just declaration.
>>
> what about __maybe_unused instead on inline and keep in header.
>
> Anyhow, I do not have any personal choice here.
This just shouldn't be defined in header because that makes it
spreading over many object files. There are just no benefits.
Best regards,
Krzysztof
Powered by blists - more mailing lists