linux-kernel - Re: [PATCH 5/5] x86, acpi, cpu-hotplug: Set persistent cpuid <-> nodeid mapping when booting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160108191305.GA1898@mtj.duckdns.org>
Date:	Fri, 8 Jan 2016 14:13:05 -0500
From:	Tejun Heo <tj@...nel.org>
To:	Tang Chen <tangchen@...fujitsu.com>
Cc:	cl@...ux.com, jiang.liu@...ux.intel.com, mika.j.penttila@...il.com,
	mingo@...hat.com, akpm@...ux-foundation.org, rjw@...ysocki.net,
	hpa@...or.com, yasu.isimatu@...il.com,
	isimatu.yasuaki@...fujitsu.com, kamezawa.hiroyu@...fujitsu.com,
	izumi.taku@...fujitsu.com, gongzhaogang@...pur.com, x86@...nel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, Gu Zheng <guz.fnst@...fujitsu.com>
Subject: Re: [PATCH 5/5] x86, acpi, cpu-hotplug: Set persistent cpuid <->
 nodeid mapping when booting.

Hello, Tang.

On Thu, Jan 07, 2016 at 12:20:25PM +0800, Tang Chen wrote:
> From: Gu Zheng <guz.fnst@...fujitsu.com>
> 
> This patch finishes step 4.

This doesn't help people trying to read the patch.  If you wanna say
it's one of the steps of something, you also need to say what the
steps are.  No need to duplicate the whole thing but a short summary
would be helpful.

> This patch set the persistent cpuid <-> nodeid mapping for all enabled/disabled
> processors at boot time via an additional acpi namespace walk for processors.

So, the patchset generally looks good to me although I'm not too
familiar with acpi.  Rafael, Len, what do you think?

Thanks.

-- 
tejun