linux-kernel - Re: [PATCH 1/5] x86, memhp, numa: Online memory-less nodes at boot time.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5695D8E2.6040908@cn.fujitsu.com>
Date:	Wed, 13 Jan 2016 12:56:02 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	Tejun Heo <tj@...nel.org>
CC:	<cl@...ux.com>, <jiang.liu@...ux.intel.com>,
	<mika.j.penttila@...il.com>, <mingo@...hat.com>,
	<akpm@...ux-foundation.org>, <rjw@...ysocki.net>, <hpa@...or.com>,
	<yasu.isimatu@...il.com>, <isimatu.yasuaki@...fujitsu.com>,
	<kamezawa.hiroyu@...fujitsu.com>, <izumi.taku@...fujitsu.com>,
	<gongzhaogang@...pur.com>, <x86@...nel.org>,
	<linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>, <tangchen@...fujitsu.com>
Subject: Re: [PATCH 1/5] x86, memhp, numa: Online memory-less nodes at boot
 time.

Hi tj,

On 01/09/2016 02:28 AM, Tejun Heo wrote:
> Hello,
>
> On Thu, Jan 07, 2016 at 12:20:21PM +0800, Tang Chen wrote:
>> +static void __init init_memory_less_node(int nid)
>>   {
>> +	unsigned long zones_size[MAX_NR_ZONES] = {0};
>> +	unsigned long zholes_size[MAX_NR_ZONES] = {0};
> It doesn't cause any functional difference but it's a bit weird to use
> {0} because it explicitly says to initialize the first element to 0
> when the whole array needs to be cleared.  Wouldnt { } make more sense?

Yes. Will fix them.

>
>> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
>> index e23a9e7..9c4d4d5 100644
>> --- a/include/linux/mmzone.h
>> +++ b/include/linux/mmzone.h
>> @@ -736,6 +736,7 @@ static inline bool is_dev_zone(const struct zone *zone)
>>   
>>   extern struct mutex zonelists_mutex;
>>   void build_all_zonelists(pg_data_t *pgdat, struct zone *zone);
>> +void build_zonelists(pg_data_t *pgdat);
> This isn't used in this patch.  Contamination?

Sorry, I tried to build zone lists here. But it totally unnecessary and 
led to some problems.

I forgot to remove them when I fixed the problems. Will remove them.

Thx.

>
> Thanks.
>