linux-kernel - [PATCH] logfs: fix logfs build errors and dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <56900D3E.50200@infradead.org>
Date:	Fri, 8 Jan 2016 11:25:50 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	LKML <linux-kernel@...r.kernel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Joern Engel <joern@...fs.org>,
	Prasad Joshi <prasadjoshi.linux@...il.com>, logfs@...fs.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: [PATCH] logfs: fix logfs build errors and dependencies

From: Randy Dunlap <rdunlap@...radead.org>

Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m:

fs/built-in.o: In function `logfs_mount':
super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd'
fs/built-in.o: In function `logfs_get_sb_bdev':
(.text+0x93530): undefined reference to `logfs_get_sb_mtd'

This change allows CONFIG_BLOCK and CONFIG_MTD to be disabled, but
if either of them is enabled, CONFIG_LOGFS is limited (restricted) by
the setting of the former symbol(s).

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc:	Joern Engel <joern@...fs.org>
Cc:	Prasad Joshi <prasadjoshi.linux@...il.com>
Cc:	logfs@...fs.org
---
 fs/logfs/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Found in linux-next but applies to mainline also.

--- linux-next-20160108.orig/fs/logfs/Kconfig
+++ linux-next-20160108/fs/logfs/Kconfig
@@ -1,6 +1,7 @@
 config LOGFS
 	tristate "LogFS file system"
-	depends on (MTD || BLOCK)
+	depends on BLOCK || BLOCK=n
+	depends on MTD || MTD=n
 	select ZLIB_INFLATE
 	select ZLIB_DEFLATE
 	select CRC32