linux-kernel - Re: [PATCH 8/8] [media] omap3isp: Check v4l2_of_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15964645.FOqpCbqGqp@avalon>
Date:	Mon, 11 Jan 2016 03:58:09 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH 8/8] [media] omap3isp: Check v4l2_of_parse_endpoint() return value

Hi Javier,

Thank you for the patch.

On Thursday 07 January 2016 15:27:22 Javier Martinez Canillas wrote:
> The v4l2_of_parse_endpoint() function can fail so check the return value.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
> 
>  drivers/media/platform/omap3isp/isp.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c
> b/drivers/media/platform/omap3isp/isp.c index 79a0b953bba3..891e54394a1c
> 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2235,8 +2235,11 @@ static int isp_of_parse_node(struct device *dev,
> struct device_node *node, struct isp_bus_cfg *buscfg = &isd->bus;
>  	struct v4l2_of_endpoint vep;
>  	unsigned int i;
> +	int ret;
> 
> -	v4l2_of_parse_endpoint(node, &vep);
> +	ret = v4l2_of_parse_endpoint(node, &vep);
> +	if (ret)
> +		return ret;
> 
>  	dev_dbg(dev, "parsing endpoint %s, interface %u\n", node->full_name,
>  		vep.base.port);

-- 
Regards,

Laurent Pinchart