linux-kernel - Re: [PATCH] arm: irq: l2c: do not print error in case of missing l2c from dtb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5694BABF.3070200@samsung.com>
Date:	Tue, 12 Jan 2016 09:35:11 +0100
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Joe Perches <joe@...ches.com>, Andi Shyti <andi.shyti@...sung.com>,
	linux-arm-kernel@...ts.infradead.org
Cc:	linux@....linux.org.uk, tony@...mide.com, robh@...nel.org,
	tglx@...utronix.de, olof@...om.net, tomasz.figa@...il.com,
	jiang.liu@...ux.intel.com, yamada.masahiro@...ionext.com,
	linux-kernel@...r.kernel.org, k.kozlowski@...sung.com,
	andi@...zian.org
Subject: Re: [PATCH] arm: irq: l2c: do not print error in case of missing l2c
 from dtb

Hello,

On 2016-01-12 08:11, Joe Perches wrote:
> On Tue, 2016-01-12 at 15:34 +0900, Andi Shyti wrote:
>> In some architectures the L2 cache controller is integrated in the
>> processor's block itself and it doesn't use any external cache
>> controller. This means that an entry in the board's dtb related
>> to the l2c is not necessary.
>>
>> Distinguish between error codes and print just an information in
>> case of -ENODEV.
> trivia:
>
>> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
> []
>> @@ -95,7 +95,9 @@ void __init init_IRQ(void)
>>   			outer_cache.write_sec = machine_desc->l2c_write_sec;
>>   		ret = l2x0_of_init(machine_desc->l2c_aux_val,
>>   				   machine_desc->l2c_aux_mask);
>> -		if (ret)
>> +		if (ret == -ENODEV)
>> +			pr_info("no L2C controller entry found in the dtb\n");
> Perhaps this would be more consistent if it was
> 			pr_info("L2C: no controller entry found in the dtb\n");

Frankly I see no benefit of such message. It still might confuse users 
that there
is something wrong with your DT. When driver initialization fails with 
-ENODEV,
then no message is usually displayed.

>> +		else if (ret)
>>   			pr_err("L2C: failed to init: %d\n", ret);
>>   	}
>>   
>
>

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland