linux-kernel - Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112090532.GS19803@x1>
Date:	Tue, 12 Jan 2016 09:05:32 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()

Please refrain from replying off-list.  Adding back the Cc's.

On Tue, 12 Jan 2016, SF Markus Elfring wrote:
> > Oh, the subject line is also duff.  Please describe the changes properly.
> > 
> > "refactoring X", "making changes to Y" are not good subject lines.
> 
> Which topic would you prefer for my update suggestion instead?

This one.

"mfd: smsc-ece1099: Refactoring for smsc_i2c_probe()"

The function name and just describing the changes as "refactoring" do
not describe the changes in a helpful way.

> >> Code looks fine however.
> 
> Thanks for your look.
> 
> 
> >> Please re-submit the set with the aforementioned changes along with my:
> >>
> >> Acked-by: Lee Jones <lee.jones@...aro.org>
> 
> Do you really request that I should append this tag already to messages
> for (my adjusted) commits you can not see so far?

Yes.  The code looks fine, and if the commit log is still not up to
scratch I just won't apply it. :)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog