linux-kernel - Re: mfd-dm355evm_msp: One function call less in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160112090600.GT19803@x1>
Date:	Tue, 12 Jan 2016 09:06:00 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: mfd-dm355evm_msp: One function call less in add_child() after
 error detection

On Tue, 12 Jan 2016, SF Markus Elfring wrote:

> >> The platform_device_put() function was called in one case by the
> >> add_child() function during error handling even if the passed
> >> variable "pdev" contained a null pointer.
> >>
> >> Implementation details could be improved by the adjustment of jump targets
> >> according to the Linux coding style convention.
> >>
> >> This issue was detected by using the Coccinelle software.
> >>
> >> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> >> ---
> >>  drivers/mfd/dm355evm_msp.c | 21 ++++++++++-----------
> >>  1 file changed, 10 insertions(+), 11 deletions(-)
> > 
> > Same comments as before.
> 
> To which comments do you refer here?
> 
> Are you interested in any further clarification of open issues?

I'm sure you'll work it out. ;)

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog