[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAEnQRZBUkaFKLUZRQD3zDU4JyHbrBd+dv+vuZwMf5zjqogBijQ@mail.gmail.com>
Date: Tue, 12 Jan 2016 14:12:34 +0200
From: Daniel Baluta <daniel.baluta@...el.com>
To: Peter Meerwald-Stadler <pmeerw@...erw.net>
Cc: Cristina Moraru <cristina.moraru09@...il.com>,
Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
Lars-Peter Clausen <lars@...afoo.de>,
Ludovic Tancerel <ludovic.tancerel@...lehightech.com>,
Matt Ranostaj <mranostay@...il.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"octavian.purdila@...el.com" <octavian.purdila@...el.com>,
Daniel Baluta <daniel.baluta@...el.com>
Subject: Re: [PATCH] iio: Add TH06 Humidity and Temperature sensor driver
On Tue, Jan 12, 2016 at 1:07 PM, Peter Meerwald-Stadler
<pmeerw@...erw.net> wrote:
>
>> Add implementation for Hoperf TH06 Humidity and Temperature
>> sensor driver.
>>
>> Datasheet: http://www.hoperf.com/upload/sensor/TH06_Module_v01.pdf
>
> I think it would be good to make to manufacturer's company name (Hoperf)
> more visible in the driver; it is currently just mentioned in the commit
> message; just 'TH06' is hard to google :)
>
> maybe you could list the TODOs / unsupported features here...
>
> the I2C register layout looks close to the si7020, maybe the chip can be
> supported there without duplicating code?
Yes, they look pretty similar. We can give it a try to add the support
for TH06 into
already existing code for si7020.
There will be some fun with Kconfig part :). Any idea if Hoperf and
Silabs are related
companies :D.
thanks,
Daniel.
Powered by blists - more mailing lists