[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <201601121350.11076.linux@rainbow-software.org>
Date: Tue, 12 Jan 2016 13:50:10 +0100
From: Ondrej Zary <linux@...nbow-software.org>
To: Daniel Baluta <daniel.baluta@...el.com>
Cc: "Peter Meerwald-Stadler" <pmeerw@...erw.net>,
Cristina Moraru <cristina.moraru09@...il.com>,
Jonathan Cameron <jic23@...nel.org>,
Hartmut Knaack <knaack.h@....de>,
"Lars-Peter Clausen" <lars@...afoo.de>,
Ludovic Tancerel <ludovic.tancerel@...lehightech.com>,
Matt Ranostaj <mranostay@...il.com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"octavian.purdila@...el.com" <octavian.purdila@...el.com>
Subject: Re: [PATCH] iio: Add TH06 Humidity and Temperature sensor driver
On Tuesday 12 January 2016, Daniel Baluta wrote:
> On Tue, Jan 12, 2016 at 1:07 PM, Peter Meerwald-Stadler
>
> <pmeerw@...erw.net> wrote:
> >> Add implementation for Hoperf TH06 Humidity and Temperature
> >> sensor driver.
> >>
> >> Datasheet: http://www.hoperf.com/upload/sensor/TH06_Module_v01.pdf
> >
> > I think it would be good to make to manufacturer's company name (Hoperf)
> > more visible in the driver; it is currently just mentioned in the commit
> > message; just 'TH06' is hard to google :)
> >
> > maybe you could list the TODOs / unsupported features here...
> >
> > the I2C register layout looks close to the si7020, maybe the chip can be
> > supported there without duplicating code?
>
> Yes, they look pretty similar. We can give it a try to add the support
> for TH06 into
> already existing code for si7020.
>
> There will be some fun with Kconfig part :). Any idea if Hoperf and
> Silabs are related
> companies :D.
Looks like TH06 is just a module with Si7020 chip. Try the "Read Electronic
ID" and "Read Firmware Revision" commands from Si7020 datasheet.
--
Ondrej Zary
Powered by blists - more mailing lists