linux-kernel - Re: [PATCH] Documentation/kernel-parameters: update KMG units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160111183122.1f7e5728@lwn.net>
Date:	Mon, 11 Jan 2016 18:31:22 -0700
From:	Jonathan Corbet <corbet@....net>
To:	Robert Elliott <elliott@....com>
Cc:	akpm@...ux-foundation.org, mgorman@...hsingularity.net,
	matt@...eblueprint.co.uk, linux-doc@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/kernel-parameters: update KMG units

On Wed, 23 Dec 2015 18:38:16 -0600
Robert Elliott <elliott@....com> wrote:

> Since commit e004f3c7780d ("lib/cmdline.c: add size unit t/p/e to
> memparse") expanded memparse() to support T, P, and E units in addition
> to K, M, and G, all the kernel parameters that use that function became
> capable of more than [KMG] mentioned in kernel-parameters.txt.
> 
> Expand the introduction to the units and change all existing [KMG]
> descriptions to [KMGTPE].  cma only had [MG]; reservelow only had [K].
> 
> Add [KMGTPE] for hugepagesz and memory_corruption_check_size, which also
> use memparse().
> 
> Update two source code files with comments mentioning [KMG].

So I've ended up dropping this one from the docs tree for now.  In the
end, I just didn't want my pull request to include an explanation for why
the docs tree has a conflict on mm/page_alloc.c....  The change is good,
though, and shouldn't be lost.  I'd say that either (1) Andrew can pick
it up and merge it with the other stuff he has, or (2) we can push it
through after mm has cleared.  Either way, a version based on -mm would
be a good thing to have.

Thanks,

jon