linux-kernel - Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5301475.Pt8xa8PKiv@wuerfel>
Date:	Tue, 12 Jan 2016 15:49:52 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:	linux-arm-kernel@...ts.infradead.org, andy.gross@...aro.org,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	Rob Herring <robh+dt@...nel.org>, linux-kernel@...r.kernel.org,
	Stephen Boyd <sboyd@...eaurora.org>
Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node

On Tuesday 12 January 2016 14:18:53 Srinivas Kandagatla wrote:
> On 12/01/16 14:00, Arnd Bergmann wrote:
> > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote:
> >> To be consistent with other nodes move sdhci node under the soc node,
> >> rather than using lable references.
> >>
> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> >>
> >
> > Maybe remove the label as well if you are no longer using it?
> Label "sdhc_1" in this case is used in aliases node.
> 

Ok, nevermind then.

> My understanding so far was qcom specific dt want to use hierarchical dt 
> nodes in the board files, but this brings the question of should we 
> delete all the unused labels.
> 
> IMO, some unused labels are harmless and would give more consistency to 
> the reader, removing them might not add great value.

Fair enough.

	Arnd