linux-kernel - Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87oacp5zl7.fsf@dell.be.48ers.dk>
Date:	Wed, 13 Jan 2016 15:22:12 +0100
From:	Peter Korsgaard <peter@...sgaard.com>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"Rob Herring" <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	devicetree@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org,
	Javier Martinez Canillas <javier@...hile0.org>,
	Lee Jones <lee.jones@...aro.org>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A

>>>>> "Wenyou" == Wenyou Yang <wenyou.yang@...el.com> writes:

 > This patch adds new regulator driver to support ACT8945A MFD
 > chip's regulators.

 > The ACT8945A has three step-down DC/DC converters and four
 > low-dropout regulators.

 > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>

Isn't the regulator part of the act8945a identical to act8865? Can't we
just use the existing act8865-regulator.c driver? (E.G. support 8865
variant in the mfd driver, but only register the regulator sub device?)

-- 
Bye, Peter Korsgaard