linux-kernel - RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A243641D63EBC6E@penmbx01>
Date:	Thu, 14 Jan 2016 01:23:39 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Peter Korsgaard <peter@...sgaard.com>
CC:	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	"Rob Herring" <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Javier Martinez Canillas <javier@...hile0.org>,
	Lee Jones <lee.jones@...aro.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
 ACT8945A

> -----Original Message-----
> From: Peter Korsgaard [mailto:jacmet@...il.com] On Behalf Of Peter Korsgaard
> Sent: 2016年1月13日 22:22
> To: Yang, Wenyou <Wenyou.Yang@...el.com>
> Cc: Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>;
> Rob Herring <robh+dt@...nel.org>; Pawel Moll <pawel.moll@....com>; Mark
> Rutland <mark.rutland@....com>; Ian Campbell <ijc+devicetree@...lion.org.uk>;
> Kumar Gala <galak@...eaurora.org>; Krzysztof Kozlowski
> <k.kozlowski@...sung.com>; devicetree@...r.kernel.org; Ferre, Nicolas
> <Nicolas.FERRE@...el.com>; linux-kernel@...r.kernel.org; Javier Martinez
> Canillas <javier@...hile0.org>; Lee Jones <lee.jones@...aro.org>; linux-arm-
> kernel@...ts.infradead.org
> Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
> ACT8945A
> 
> >>>>> "Wenyou" == Wenyou Yang <wenyou.yang@...el.com> writes:
> 
>  > This patch adds new regulator driver to support ACT8945A MFD  > chip's
> regulators.
> 
>  > The ACT8945A has three step-down DC/DC converters and four  > low-dropout
> regulators.
> 
>  > Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> 
> Isn't the regulator part of the act8945a identical to act8865? Can't we just use the
> existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd driver,
> but only register the regulator sub device?)

Yes, the regulator part of the act8945a is identical to act8865.

But the act8865-regulator driver is a struct i2c_driver,  and the mfd sub-device driver is a platform_driver driver, it is not easy to use it.

> 
> --
> Bye, Peter Korsgaard


Best Regards,
Wenyou Yang