[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6116283.ubGS0D0e49@wuerfel>
Date: Wed, 13 Jan 2016 21:45:05 +0100
From: Arnd Bergmann <arnd@...db.de>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: mmarek@...e.com, Peter Chen <peter.chen@...escale.com>,
Randy Dunlap <rdunlap@...radead.org>,
Joern Engel <joern@...fs.org>,
Prasad Joshi <prasadjoshi.linux@...il.com>,
linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] logfs: clarify MTD dependency
On Wednesday 13 January 2016 12:39:18 Andrew Morton wrote:
>
> Randy's "logfs: fix logfs build errors and dependencies" is an
> only-in-mm thing. So it would make sense to combine the two patches
> into a single one and to give that an appropriate changelog.
>
> How does this look? (Primary author was chosen randomly)
>
>
> From: Arnd Bergmann <arnd@...db.de>
> Subject: logfs: fix logfs build errors and dependencies
>
> Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m:
>
> fs/built-in.o: In function `logfs_mount':
> super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd'
> fs/built-in.o: In function `logfs_get_sb_bdev':
> (.text+0x93530): undefined reference to `logfs_get_sb_mtd'
>
> This patch avoids the error by changing the dependencies of
> logfs in a way that we can no longer configure logfs as built-in
> when the MTD core is a loadable module, while leaving the
> dependency to require at least one of MTD or BLOCK to be
> enabled.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Michal Marek <mmarek@...e.cz>
> Cc: Peter Chen <peter.chen@...escale.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Joern Engel <joern@...fs.org>
> Cc: Prasad Joshi <prasadjoshi.linux@...il.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
>
Looks good, thanks!
Arnd
Powered by blists - more mailing lists