linux-kernel - Re: [PATCH v5 2/2] xen_balloon: support memory auto onlining policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160113204638.GZ3485@olila.local.net-space.pl>
Date:	Wed, 13 Jan 2016 21:46:38 +0100
From:	Daniel Kiper <daniel.kiper@...cle.com>
To:	Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:	linux-mm@...ck.org, Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	Tang Chen <tangchen@...fujitsu.com>,
	David Vrabel <david.vrabel@...rix.com>,
	David Rientjes <rientjes@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Xishi Qiu <qiuxishi@...wei.com>,
	Mel Gorman <mgorman@...hsingularity.net>,
	"K. Y. Srinivasan" <kys@...rosoft.com>,
	Igor Mammedov <imammedo@...hat.com>,
	Kay Sievers <kay@...y.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v5 2/2] xen_balloon: support memory auto onlining policy

On Wed, Jan 13, 2016 at 06:32:30PM +0100, Vitaly Kuznetsov wrote:
> Add support for the newly added kernel memory auto onlining policy to Xen
> ballon driver.
>
> Suggested-by: Daniel Kiper <daniel.kiper@...cle.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>

In general Reviewed-by: Daniel Kiper <daniel.kiper@...cle.com>
but one nitpick below...

Thank you for doing this work.

> ---
> Changes since v4:
> - 'dom0' -> 'control domain', 'domU' -> 'target domain' in Kconfig
>   [David Vrabel]
> - always call add_memory_resource() with memhp_auto_online [David Vrabel]
> ---
>  drivers/xen/Kconfig   | 20 +++++++++++++-------
>  drivers/xen/balloon.c | 11 ++++++++++-
>  2 files changed, 23 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig
> index 73708ac..addcb7f 100644
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -37,23 +37,29 @@ config XEN_BALLOON_MEMORY_HOTPLUG
>
>  	  Memory could be hotplugged in following steps:
>
> -	    1) dom0: xl mem-max <domU> <maxmem>
> +	    1) target domain: ensure that memory auto online policy is in
> +	       effect by checking /sys/devices/system/memory/auto_online_blocks
> +	       file (should be 'online').
> +
> +	    2) control domain: xl mem-max <target-domain> <maxmem>
>  	       where <maxmem> is >= requested memory size,
>
> -	    2) dom0: xl mem-set <domU> <memory>
> +	    3) control domain: xl mem-set <target-domain> <memory>
>  	       where <memory> is requested memory size; alternatively memory
>  	       could be added by writing proper value to
>  	       /sys/devices/system/xen_memory/xen_memory0/target or
>  	       /sys/devices/system/xen_memory/xen_memory0/target_kb on dumU,

Please change "dumU" to "target domain".

Daniel