linux-kernel - Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbswphyz_CBdFKJae-FsLTKHKqzBDQQAmZbWfdXp5ho4w@mail.gmail.com>
Date:	Thu, 14 Jan 2016 10:12:41 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] soc: versatile: Drop a useless static qualifier

On Mon, Jan 11, 2016 at 7:16 AM, Christophe JAILLET
<christophe.jaillet@...adoo.fr> wrote:

> There is no need to have the 'struct regmap *syscon_regmap' variable
> static in the probe function.
> It only wastes a few bytes of memory.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Sorry a copy-paste error ... used to have it as a global.

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

I think you should send this to arm@...nel.org for application
as a fixup to the ARM SoC tree. Include my Review tag.

Yours,
Linus Walleij