linux-kernel - RE: [PATCH v3 2/2] s5p-mfc: add the support of V4L2_CID_MPEG_VIDEO_FORCE_I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <00b301d14ef0$8f51df00$adf59d00$@samsung.com>
Date:	Thu, 14 Jan 2016 18:25:26 +0100
From:	Kamil Debski <k.debski@...sung.com>
To:	'Wu-Cheng Li' <wuchengli@...omium.org>, pawel@...iak.com,
	mchehab@....samsung.com, hverkuil@...all.nl, crope@....fi,
	standby24x7@...il.com, nicolas.dufresne@...labora.com,
	ricardo.ribalda@...il.com, ao2@....it, bparrot@...com,
	kyungmin.park@...sung.com, jtp.park@...sung.com
Cc:	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-api@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	tiffany.lin@...iatek.com, djkurtz@...omium.org
Subject: RE: [PATCH v3 2/2] s5p-mfc: add the support of
 V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME.

Hi,

> From: Wu-Cheng Li [mailto:wuchengli@...omium.org]
> Sent: Thursday, January 14, 2016 3:50 PM
> To: pawel@...iak.com; mchehab@....samsung.com; hverkuil@...all.nl;
> k.debski@...sung.com; crope@....fi; standby24x7@...il.com;
> wuchengli@...omium.org; nicolas.dufresne@...labora.com;
> ricardo.ribalda@...il.com; ao2@....it; bparrot@...com;
> kyungmin.park@...sung.com; jtp.park@...sung.com
> Cc: linux-media@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> api@...r.kernel.org; linux-arm-kernel@...ts.infradead.org;
> tiffany.lin@...iatek.com; djkurtz@...omium.org
> Subject: [PATCH v3 2/2] s5p-mfc: add the support of
> V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME.

However simple the patch is, please do provide a commit message.
Please write something. 

Best wishes,
Kamil

> Signed-off-by: Wu-Cheng Li <wuchengli@...omium.org>
> ---
>  drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> index 0434f02..974b4c5 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c
> @@ -212,6 +212,14 @@ static struct mfc_control controls[] = {
>  		.menu_skip_mask = 0,
>  	},
>  	{
> +		.id = V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME,
> +		.type = V4L2_CTRL_TYPE_BUTTON,
> +		.minimum = 0,
> +		.maximum = 0,
> +		.step = 0,
> +		.default_value = 0,
> +	},
> +	{
>  		.id = V4L2_CID_MPEG_VIDEO_VBV_SIZE,
>  		.type = V4L2_CTRL_TYPE_INTEGER,
>  		.minimum = 0,
> @@ -1423,6 +1431,10 @@ static int s5p_mfc_enc_s_ctrl(struct v4l2_ctrl
*ctrl)
>  	case V4L2_CID_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE:
>  		ctx->force_frame_type = ctrl->val;
>  		break;
> +	case V4L2_CID_MPEG_VIDEO_FORCE_I_FRAME:
> +		ctx->force_frame_type =
> +
> 	V4L2_MPEG_MFC51_VIDEO_FORCE_FRAME_TYPE_I_FRAME;
> +		break;
>  	case V4L2_CID_MPEG_VIDEO_VBV_SIZE:
>  		p->vbv_size = ctrl->val;
>  		break;
> --
> 2.6.0.rc2.230.g3dd15c0