linux-kernel - Re: [PATCH v2] reboot: Backup orderly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160115101459.GB23349@gmail.com>
Date:	Fri, 15 Jan 2016 11:14:59 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Keerthy <a0393675@...com>, Keerthy <j-keerthy@...com>,
	linux-kernel@...r.kernel.org, edubezval@...il.com,
	grygorii.strashko@...com, nm@...com, linux-pm@...r.kernel.org,
	linux-omap@...r.kernel.org, joel@....id.au,
	akpm@...ux-foundation.org, linux-arm-kernel@...ts.infradead.org,
	peterz@...radead.org, dyoung@...hat.com, josh@...htriplett.org,
	mpe@...erman.id.au, Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH v2] reboot: Backup orderly_poweroff


* One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk> wrote:

> > If kernel_power_off() is called then the system should power off. No ifs and 
> > whens.
> 
> Even if it doesn't the watchdog should kill it. 
> 
> That is broken on some platforms on the watchdog side as the
> watchdog shuts down during our power off callbacks - because the system
> firmware is too stupid to reset the watchdog as it powers back up (so
> keeps rebooting).
> 
> If you watchdog and firmware function properly you shouldn't even have to
> care if you crash during the kernel power off.

That's a good point as well - if the system is 'stuck' for some notion of stuck, 
then watchdog drivers can help.

Here it's unclear whether user-space even called the sys_reboot() system call.

Thanks,

	Ingo