linux-kernel - Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160115142319.51f79994@endymion.delvare>
Date:	Fri, 15 Jan 2016 14:23:19 +0100
From:	Jean Delvare <jdelvare@...e.de>
To:	Michał Kępień <kernel@...pniu.pl>
Cc:	Pali Rohár <pali.rohar@...il.com>,
	Andy Lutomirski <luto@...nel.org>,
	Jean Delvare <jdelvare@...e.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable <stable@...r.kernel.org>
Subject: Re: [PATCH] dell-wmi: Stop storing pointers to DMI tables

On Thu, 14 Jan 2016 10:52:04 +0100, Michał Kępień wrote:
> > > Hi Andy, I looked at this patch, but I think some people from -mm or DMI
> > > code should look at it as it is memory problem... We also has one in
> > > dell-laptop.ko (wrong API usage) and so -mm people could know it better.
> 
> > There are at least two platform drivers (dell-wmi and dell-laptop)
> > that don't play well with the current interface.  This patch is
> > intended to fix one of them.
> 
> Pali, Andy,
> 
> Could you point out the exact place where dell-laptop errs?  AFAICT, it
> only has one use of dmi_walk(), the callback there calls
> parse_da_table(), which does the right thing, i.e. krealloc()'ing memory
> and then memcpy()'ing table contents there...

FWIW I can't see any problem with dell-laptop either.

-- 
Jean Delvare
SUSE L3 Support