linux-kernel - Re: [PATCH] amdkfd: Copy from the proper user command pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160115190939.GE17997@ZenIV.linux.org.uk>
Date:	Fri, 15 Jan 2016 19:09:39 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] amdkfd: Copy from the proper user command pointer

On Fri, Jan 15, 2016 at 07:26:44PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> 8f1d57c17248 ("amdkfd: don't open-code memdup_user()") mistakenly uses
> an uninitialized local pointer, gcc complains:
> 
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c: In function ‘kfd_ioctl_dbg_address_watch’:
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:562:12: warning: ‘args_buff’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>     args_buff = memdup_user(args_buff,
>                 ^
> 
> Fix it.

Mea culpa...  Applied, and I wonder how the hell I'd missed that..