linux-kernel - Re: [PATCH v4] serial: 8250: add gpio support to exar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160118140641.GA22985@sudip-laptop>
Date:	Mon, 18 Jan 2016 19:36:41 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Rob Groner <rgroner@....com>
Subject: Re: [PATCH v4] serial: 8250: add gpio support to exar

On Mon, Jan 18, 2016 at 03:39:01PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2016 at 2:10 PM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> > can be controlled using gpio interface.
> > Add support to use these pins.
> 
> Looks better, but…
> 
> >  drivers/gpio/Kconfig                |   7 ++
> >  drivers/gpio/Makefile               |   1 +
> 
> Why is it here?
> 
> >  drivers/tty/serial/8250/8250_gpio.c | 243 ++++++++++++++++++++++++++++++++++++

OOPS... I am sorry, I have made a complete mess of this patch. :(
This was supposed to have drivers/gpio/gpio-exar.c and
not drivers/tty/serial/8250/8250_gpio.c
The entire gpio related code was moved to drivers/gpio/gpio-exar.c and
8250_pci.c was only adding the platform device.
I will post the correct patch tomorrow.
Sorry again.

regards
sudip