linux-kernel - Re: [PATCH, RESEND^2] ssb: mark ssb_bus_register as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877fj567ri.fsf@kamboji.qca.qualcomm.com>
Date:	Tue, 19 Jan 2016 15:03:45 +0200
From:	Kalle Valo <kvalo@...eaurora.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org,
	Hauke Mehrtens <hauke@...ke-m.de>,
	Rafał Miłecki <zajec5@...il.com>,
	linux-kernel@...r.kernel.org, Michael Buesch <m@...s.ch>,
	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH, RESEND^2] ssb: mark ssb_bus_register as __maybe_unused

Arnd Bergmann <arnd@...db.de> writes:

> The SoC variant of the ssb code is now optional like the other
> ones, which means we can build the framwork without any
> front-end, but that results in a warning:
>
> drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]
>
> This annotates the ssb_bus_register function as __maybe_unused to
> shut up the warning. A configuration like this will not work on
> any hardware of course, but we still want this to silently build
> without warnings if the configuration is allowed in the first
> place.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 845da6e58e19 ("ssb: add Kconfig entry for compiling SoC related code")
> Acked-by: Michael Buesch <m@...s.ch>
> ---
> Resent to linux-wireless as requested

Thanks, and sorry for the hassle. I'm planning to push this to 4.5.

-- 
Kalle Valo