linux-kernel - Re: Nokia N900: musb is in wrong state after boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160119203314.GE19432@atomide.com>
Date:	Tue, 19 Jan 2016 12:33:15 -0800
From:	Tony Lindgren <tony@...mide.com>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org,
	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>,
	Sebastian Reichel <sre@...nel.org>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Pavel Machek <pavel@....cz>, Nishanth Menon <nm@...com>
Subject: Re: Nokia N900: musb is in wrong state after boot

Hi,

* Pali Rohár <pali.rohar@...il.com> [160109 07:16]:
> Hello,
> 
> when I boot 4.4.0-rc7+ kernel compiled with g_nokia into zImage on Nokia 
> N900 into userspace then usb gadget (g_nokia) does not work. Notebook, 
> connected on other side does not see any usb device... Connecting and 
> disconnecting cable does not change anything, still not work.
> 
> But if I run this command
> $ echo peripheral > /sys/bus/platform/devices/musb-hdrc.0.auto/mode 

.
> 
> then gadget starts working. Other side see usb device and can use it. 
> Also connecting and disconnecting usb cable working fine. After 
> connecting it again, usb device OK.

N900 had the PHY interrupt wired to the bq chip instead of twl4030, right?

You can fix this issue similar to phy-twl4030-usb.c. In function
twl4030_phy_power_on() we call schedule_delayed_work() that checks
the state of the ID pin on boot up.

I think that's only needed for the i2c based PHY's with MUSB, with
the others the USB driver has a better idea of the current state.

Regards,

Tony