linux-kernel - Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160120133400.GQ27085@kernel.org>
Date:	Wed, 20 Jan 2016 10:34:00 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Jiri Olsa <jolsa@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	Wang Nan <wangnan0@...wei.com>,
	Don Zickus <dzickus@...hat.com>,
	Pekka Enberg <penberg@...nel.org>,
	Moinuddin Quadri <moin18@...il.com>
Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view
 (v2)

Em Wed, Jan 20, 2016 at 09:56:47AM +0900, Namhyung Kim escreveu:
> On Tue, Jan 19, 2016 at 07:24:49PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Jan 19, 2016 at 11:12:04PM +0100, Andi Kleen escreveu:
> In this case, do you want this?
 
>   $ perf report --percent-limit 0.5
>   ...
>   +    1.00%  perf  perf  some_function
>            some_function
>          - common_caller
>             - 0.6% caller1

> > > Also would be nice to be able to set it dynamically from the UI.

> > To set the mim percent? Yeah, we need to allow setting all those knobs
> > from the UI.

> > I.e. should be like when we press '/' to set a substring filter.
 
> Yes, how about 'L' key for limit?

We have other limits we can set, perhaps we should use 'l' and do
something like mutt does, i.e. accept expressions that would allow us
to have a flexible way of setting limits, not just for the percentage
thresholds for hist_entries (callchains later).

- Arnaldo