linux-kernel - Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xr3hcqlix.fsf@unicorn.mansr.com>
Date:	Wed, 20 Jan 2016 16:10:46 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Marc Zyngier <marc.zyngier@....com>
Cc:	Marc Gonzalez <marc_gonzalez@...madesigns.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jason Cooper <jason@...edaemon.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux ARM <linux-arm-kernel@...ts.infradead.org>,
	Sebastian Frias <sf84@...oste.net>
Subject: Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt controller

Marc Zyngier <marc.zyngier@....com> writes:

>> +	if (of_property_read_u32(node, "reg", &ctl))
>> +		panic("%s: failed to get reg base", node->name);
>> +
>> +	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>> +	chip->ctl = ctl;
>> +	chip->base = base;

As I said before, this assumes the outer DT node uses a ranges
property.  Normally reg properties work the same whether they specify an
offset within an outer "ranges" or have a full address directly.  It
would be easy enough to make this work with either, so I don't see any
reason not to.

-- 
Måns Rullgård