linux-kernel - Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1xlh7kowyo.fsf@unicorn.mansr.com>
Date:	Wed, 20 Jan 2016 19:46:39 +0000
From:	Måns Rullgård <mans@...sr.com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Julian Margetson <runaway@...dw.ms>, Tejun Heo <tj@...nel.org>,
	linux-ide@...r.kernel.org,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko <andy.shevchenko@...il.com> writes:

> On Wed, Jan 20, 2016 at 9:24 PM, Måns Rullgård <mans@...sr.com> wrote:
>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>>
>>> On Wed, 2016-01-20 at 18:50 +0000, Måns Rullgård wrote:
>>>> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
>>>>
>>>> > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver).
>>>> > >
>>>> > > Code here:
>>>> > > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata
>>>> >
>>>> > Thanks for testing!
>>>>
>>>> Have you had time to look any more at these patches?
>>>
>>> Not yet.
>>> I will look soon for sure.
>>>
>>> One comment still regarding to lli types. We can avoid warnings by
>>> using (__force u32) in macros.
>>
>> But that won't give the benefits of having the types checked.
>
> You mean if we access the lli->field directly? I didn't quite get what
> use case you are keeping in mind.

Yes, accessing any of those fields directly with my patch gives a sparse
warning.  It's situations like these those checks are intended for.
Defeating them seems foolish to me.

-- 
Måns Rullgård