linux-kernel - Re: [PATCH 3/5] HSI: nokia-modem: add n950 and n9 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 13:30:37 +0100
From:	Sebastian Reichel <sre@...nel.org>
To:	Rob Herring <robh@...nel.org>
Cc:	Tony Lindgren <tony@...mide.com>,
	Benoît Cousson <bcousson@...libre.com>,
	Paul Walmsley <paul@...an.com>,
	Aaro Koskinen <aaro.koskinen@....fi>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>, linux-omap@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] HSI: nokia-modem: add n950 and n9 support

Hi Rob,

On Wed, Jan 20, 2016 at 10:49:19AM -0600, Rob Herring wrote:
> On Sun, Jan 17, 2016 at 04:49:07PM +0100, Sebastian Reichel wrote:
> > The Nokia N950 and Nokia N9 also have a SSI connected
> > modem, which use the same protocols as the Nokia N900,
> > but with slightly other GPIO setup and increased link
> > speed (96000 kbps instead of 55000 kbps).
> 
> "slightly other" does not make sense.

I meant to write "slightly different", but how about:

The Nokia N950 and Nokia N9 also have a SSI connected
modem, which use the same protocols as the Nokia N900,
but with increased link speed (96000 kbps instead of
55000 kbps) and with less GPIOs.

> > Since it's unclear, if the N950 and the N9 use exactly
> > the same modem, each of them gets their own compatible
> > string.
> > 
> > Signed-off-by: Sebastian Reichel <sre@...nel.org>
> > ---
> >  Documentation/devicetree/bindings/hsi/nokia-modem.txt | 12 +++++++-----
> >  drivers/hsi/clients/nokia-modem.c                     |  2 ++
> >  2 files changed, 9 insertions(+), 5 deletions(-)
> 
> Otherwise,
> 
> Acked-by: Rob Herring <robh@...nel.org>

Thanks for the review.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)