linux-kernel - Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160122080004.GN6357@twins.programming.kicks-ass.net>
Date:	Fri, 22 Jan 2016 09:00:04 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [PATCH] perf core: Get rid of 'uses dynamic stack allocation'
 warning

On Fri, Jan 22, 2016 at 06:52:01AM +0000, Wang Nan wrote:
> On s390 with CONFIG_WARN_DYNAMIC_STACK set, 'uses dynamic stack
> allocation' warning is issued when defining 'struct perf_sample_data'
> local variable.
> 
> This patch suppress this warning by allocating extra 255 bytes and
> compute aligned pointer manually.

I've seen the warning and always wondered wtf it was about. This
Changelog doesn't actually explain what the problem is, so I cannot
judge the solution.

That said, 255 extra bytes does sound excessive just to avoid a warn.