linux-kernel - Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56A1EF55.5000909@huawei.com>
Date:	Fri, 22 Jan 2016 16:59:01 +0800
From:	Zhong Kaihua <zhongkaihua@...wei.com>
To:	Sudeep Holla <sudeep.holla@....com>
CC:	<robh+dt@...nel.org>, <pawel.moll@....com>, <mark.rutland@....com>,
	<ijc+devicetree@...lion.org.uk>, <galak@...eaurora.org>,
	<catalin.marinas@....com>, <will.deacon@....com>,
	<xuyiping@...ilicon.com>, <xuwei5@...ilicon.com>,
	<bintian.wang@...wei.com>, <haojian.zhuang@...aro.org>,
	<devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <puck.chen@...ilicon.com>,
	<w.f@...wei.com>, <dan.zhao@...ilicon.com>,
	<kong.kongxinwei@...ilicon.com>
Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes

On 2016/1/19 21:37, Sudeep Holla wrote:
> 
> 
> On 19/01/16 10:51, Zhong Kaihua wrote:
>> arm64: dts: Add Hi6220 gpio configuration nodes
>>
>> Signed-off-by: Zhong Kaihua <zhongkaihua@...wei.com>
>>                 Kong Xinwei <kong.kongxinwei@...ilicon.com>
>>
>> Acked-by: Rob Herring <robh@...nel.org>
>> ---
>>   .../devicetree/bindings/gpio/gpio-hi6220.txt       |  23 +
>>   arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts     |   1 +
>>   arch/arm64/boot/dts/hisilicon/hi6220.dtsi          | 259 +++++++++
>>   arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi      | 607 +++++++++++++++++++++
>>   4 files changed, 890 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>>   create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
>>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> new file mode 100644
>> index 0000000..a9cbf21
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
>> @@ -0,0 +1,23 @@
>> +Hisilicon Hi6220 GPIO controller bindings
>> +
>> +Required properties:
>> +    - compatible: "arm,pl061","arm,primecell"
>> +    - gpio-controller: Marks the device node as a GPIO controller.
>> +    - #gpio-cells: Should be 2. See gpio.txt in this directory for a
>> +         description of    the cells format.
>> +    - interrupt-controller: Mark the device node as an interrupt controller
>> +
> 
> Why do you need extra binding document here as the compatible is same as
> [1] ? You can extend that if required and add example there IMO.
> 

Ok, I will remove the binding document in the next version. Thanks.