linux-kernel - Re: [PATCH v3 3/5] firmware: fold successful fw read early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Jan 2016 06:56:52 -0500
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	"Luis R. Rodriguez" <mcgrof@...e.com>
Cc:	Josh Boyer <jwboyer@...oraproject.org>,
	"Luis R. Rodriguez" <mcgrof@...not-panic.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Ming Lei <ming.lei@...onical.com>,
	Johannes Berg <johannes@...solutions.net>,
	Andy Lutomirski <luto@...capital.net>,
	Jonathan Corbet <corbet@....net>,
	David Woodhouse <dwmw2@...radead.org>,
	David Howells <dhowells@...hat.com>,
	Seth Forshee <seth.forshee@...onical.com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Michal Marek <mmarek@...e.cz>,
	Matthew Garrett <mjg59@...f.ucam.org>, kyle@...nel.org,
	dmitry.kasatkin@...il.com, Vivek Goyal <vgoyal@...hat.com>,
	Brian Norris <computersforpeace@...il.com>,
	Kees Cook <keescook@...omium.org>, shuahkh@....samsung.com,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-security-module <linux-security-module@...r.kernel.org>,
	keyrings@...ux-nfs.org,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/5] firmware: fold successful fw read early

On Fri, 2016-01-22 at 02:45 +0100, Luis R. Rodriguez wrote:
> On Mon, Jan 04, 2016 at 03:48:29PM -0500, Josh Boyer wrote:
> > On Wed, Dec 23, 2015 at 4:34 PM, Luis R. Rodriguez
> > <mcgrof@...not-panic.com> wrote:
> > > From: David Howells <dhowells@...hat.com>
> > >
> > > We'll be folding in some more checks on fw_read_file_contents(),
> > > this will make the success case easier to follow.
> > >
> > > Signed-off-by: David Howells <dhowells@...hat.com>
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@...e.com>
> > 
> > Reviewed-by: Josh Boyer <jwboyer@...oraproject.org>
> 
> Thanks Josh.
> 
> Mimi, this is the other patch that  I was referring to.

After this patch set, replacing the fw_read_file calls with the
kernel_read_file_from_path() version is straight forward.  Nice!

Mimi