linux-kernel - Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1453463800.2521.189.camel@linux.intel.com>
Date:	Fri, 22 Jan 2016 13:56:40 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Måns Rullgård <mans@...sr.com>
Cc:	Andy Shevchenko <andy.shevchenko@...il.com>,
	Julian Margetson <runaway@...dw.ms>, Tejun Heo <tj@...nel.org>,
	linux-ide@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find
 dma channel

On Fri, 2016-01-22 at 11:13 +0000, Måns Rullgård wrote:
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> writes:
> > On Wed, 2016-01-20 at 20:07 +0000, Måns Rullgård wrote:
> > > Andy Shevchenko <andy.shevchenko@...il.com> writes:

> > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ?
> 
> Is there a wrong indentation somewhere?  I don't see it.

My git diff shows this in particular:

--- a/drivers/dma/dw/core.c
+++ b/drivers/dma/dw/core.c
@@ -45,10 +45,10 @@
                        DW_DMA_MSIZE_16;                        \
                u8 _dmsize = _is_slave ? _sconfig->dst_maxburst
:       \
                        DW_DMA_MSIZE_16;                        \
-               u8 _dms = (_is_slave && _dwc->direction ==
DMA_MEM_TO_DEV) ? \
-                       _dwc->p_master : _dwc-
>m_master;                \
-               u8 _sms = (_is_slave && _dwc->direction ==
DMA_DEV_TO_MEM) ? \
-                       _dwc->p_master : _dwc-
>m_master;                \
+               u8 _dms = (_is_slave && _dwc->direction ==
DMA_MEM_TO_DEV) ?    \
+                          _dwc->p_master : _dwc-
>m_master;                     \
+               u8 _sms = (_is_slave && _dwc->direction ==
DMA_DEV_TO_MEM) ?    \
+                          _dwc->p_master : _dwc-
>m_master;                     \

Means in your case the ' \' is used, in mine — '\t\' at the end of
lines.

> Now the question: who do you prefer to submit the series (dw_dmac)?
> > Me
> > or you?
> > 
> > In case you would like to do it (what I see in your dwc-sata branch
> > today):
> > Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> I'll fix the above, give your changes a review, and add my sign-off
> before sending the series, today or during the weekend.

OK.

Just to be sure we are on the same page. I assume your dwc-sata branch
as for submitting.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy